- Jul 21, 2023
-
-
Amit Pundir authored
* aosp/upstream-main: (27 commits) minigbm: add some validation check in cros_gralloc minigbm: update format of mediatek.c Revert "i915: Vertical align video encode buffers to macroblock size" minigbm: drv: Fix MINIGBM_DEBUG usage on Android mediatek: Add BO_USE_PROTECTED use_flag for gpu and video decoder i915: Vertical align video encode buffers to macroblock size Don't print verbose messages by default virgl: Store format modifier in blob's bo meta Fix convertToFenceHandle() minigbm: update drv_get_os_option() to try getenv() first Update usage to 64-bit virtgpu_cross_domain: fix prop query for mt8183 camera quirk virtgpu_virgl: use blobs for ABGR8888 minigbm: move camera work-around mediatek: Add BO_USE_PROTECTED use_flag to support secure buffer allocation i915: prefer tile4 for non-linear scanout buffers i915: allow linear mapping for P010 scanout minigbm: remove `close_gem_handle` mediatek: Exclude MT8173's FP16 and 10-bit ABGR support minigbm: Use clflushopt if supported ... Change-Id: I38fb3f2c699205f73633e07d1824c4fd48dac5f5 Signed-off-by:
Amit Pundir <amit.pundir@linaro.org>
-
Amit Pundir authored
Add default set of minigbm SELinux policies, to suppress audit of minigbm reading vendor.minigbm.debug property, for the devices which do not use this property. Change-Id: I277a553e869b7a53a85ca70064c2eef110afeee2 Signed-off-by:
Amit Pundir <amit.pundir@linaro.org>
-
- Jul 18, 2023
-
-
dawnhan authored
1. Check if the buffer handle - Validate if the handle is null or not - Check the size of the handle to make sure it will not cause oob read/write 2. Check num_planes to make sure it matches with numFds 3. Created b/291606090 for the follow up about updating cros_gralloc_driver level api to take cros_gralloc_handle_t BUG=b:289303132 TEST=patch the change on rvc-arc and tested with ARCVM Change-Id: Id03ec45f928fe6db62bb1722ee0dbc6c8831fd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4674736 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Dawn Han <dawnhan@google.com> Tested-by:
Dawn Han <dawnhan@google.com>
-
Dawn Han authored
Run clang-format to correct the format in mediatek.c BUG=N/A TEST=CQ Change-Id: I2c6630792ade67fd09a4fd8e7d13140ec4da7c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4517884 Commit-Queue: Dawn Han <dawnhan@google.com> Tested-by:
Dawn Han <dawnhan@google.com> Reviewed-by:
Dominik Behr <dbehr@chromium.org>
-
- Jul 07, 2023
-
-
Ren-Pei Zeng authored
This reverts commit 670301f6. Reason for revert: b/289983468 Original change's description: > i915: Vertical align video encode buffers to macroblock size > > Verically align buffers used in video encoding to the size of a > macroblock. This prevents uninitialized data from entering the encoding > pipeline, which causes quality degradations. > > BUG=b:274756117 b:277690367 > TEST=Tested by running "./video_encode_accelerator_perf_tests > --codec=av1 --bitrate=84120 180p_perf.yuv 180p_perf.json > --gtest_filter=VideoEncoderTest.MeasureProducedBitstreamQuality" on a > Rex. The average PSNR goes from 34.4939dB to 38.6649dB. > > Change-Id: I6783f1986869e11b1dd19e949d25c4450229c4c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4615698 > Tested-by:
Justin Green <greenjustin@google.com> > Commit-Queue: Justin Green <greenjustin@google.com> > Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> > Reviewed-by:
Dominik Behr <dbehr@chromium.org> BUG=b:274756117 b:277690367 Change-Id: I0ac9a1fecd74bffa9c10cebaa38469331224b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4671806 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Tested-by:
Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org>
-
- Jul 05, 2023
-
-
Amit Pundir authored
MINIGBM_DEBUG usage in drv_get_os_option() is broken on Cuttlefish at the moment and we run into following selinux denial. W libc : Access denied finding property "MINIGBM_DEBUG". I auditd : type=1400 audit(0.0:39): avc: denied { read } \ for comm="android.hardwar" name="u:object_r:default_prop:s0" \ dev="tmpfs" ino=184 scontext=u:r:hal_graphics_allocator_default:s0 \ tcontext=u:object_r:default_prop:s0 tclass=file permissive=0 On Android builds, MINIGBM_DEBUG can translate to a vendor property if not used as an env variable. To fix that property usage on Android, we start with using the proper (lowercase) Android property nomenclature. This will sadly break the usage of MINIGBM_DEBUG env variable on Android builds and will force users to use vendor.minigbm.debug property instead. Change-Id: I05a6213d2460cf5f7d20d3d04a014965ca03bebe Signed-off-by:
Amit Pundir <amit.pundir@linaro.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4630128 Reviewed-by:
Dominik Behr <dbehr@chromium.org> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Jason Macnak <natsu@google.com> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
-
- Jun 27, 2023
-
-
Jason-JH.Lin authored
BO_USE_PROTECTED use_flag is for allocating a secure buffer from GEM, so we also need to add it for the formats of gpu and video decoder. BUG=b:248609774 TEST="emerge-cherry libdrm minigbm" pass Change-Id: I36f433ac173724a4c3794ad9642dea1f8d9db051 Signed-off-by:
Jason-JH.Lin <jason-jh.lin@mediatek.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4603653 Reviewed-by:
Dominik Behr <dbehr@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Tested-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
-
Justin Green authored
Verically align buffers used in video encoding to the size of a macroblock. This prevents uninitialized data from entering the encoding pipeline, which causes quality degradations. BUG=b:274756117 b:277690367 TEST=Tested by running "./video_encode_accelerator_perf_tests --codec=av1 --bitrate=84120 180p_perf.yuv 180p_perf.json --gtest_filter=VideoEncoderTest.MeasureProducedBitstreamQuality" on a Rex. The average PSNR goes from 34.4939dB to 38.6649dB. Change-Id: I6783f1986869e11b1dd19e949d25c4450229c4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4615698 Tested-by:
Justin Green <greenjustin@google.com> Commit-Queue: Justin Green <greenjustin@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominik Behr <dbehr@chromium.org>
-
- Jun 23, 2023
-
-
Roman Stratiienko authored
Apply the same logic as ALOGV from cutils/log.h does. Change-Id: Ia372ae760a23ad193c33a9bdb30296122b6d8a3f Signed-off-by:
Roman Stratiienko <r.stratiienko@gmail.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4432230 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org>
-
- Jun 21, 2023
-
-
Bartłomiej Grzesik authored
Prior this change the format modifier was not set for blob's meta, which lead to incorrect reporting of format modifier to clients. This changes fixes this issue. BUG=b:267299128 TEST=ExoPlayer demo app Change-Id: I15c2f9095d3cb20e2a5a34d749af6657e98f7ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4628256 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
-
- Jun 16, 2023
-
-
Jason Macnak authored
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2628520 Change-Id: I1286ef4a93db07b221da38ad39516ad88c94a876 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Jason Macnak authored
... to not return address to a local stack variable. Noticed by dustingreen@ Bug: b/287536665 Test: cvd start && vts -m VtsHalGraphicsMapperV4_0Target Change-Id: Iba486270a7ae3f8fbe50b41e3ea4c32aa0c4acad Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4615434 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Auto-Submit: Jason Macnak <natsu@google.com> Tested-by:
Jason Macnak <natsu@google.com> Commit-Queue: Jason Macnak <natsu@google.com>
-
Jason Macnak authored
... to not return address to local stack variable. Upstream review: https://crrev.com/c/4615434 Bug: b/287536665 Test: cvd start && vts -m VtsHalGraphicsMapperV4_0Target Change-Id: I1f8b5e12fc77fb30bfca8dbf712efa925f45f537
-
- Jun 08, 2023
-
-
Amit Pundir authored
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2619302 Change-Id: I472acb735b4e10c8cb75a89078a81f908070e123 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Amit Pundir authored
Otherwise upstream-main branch fail to link libgbm.so: ------------------------------ //external/minigbm:libgbm link libgbm.so ld.lld: error: undefined symbol: property_get >>> referenced by drv_helpers.c:625 (external/minigbm/drv_helpers.c:625) >>> out/soong/.intermediates/external/minigbm/libgbm/android_arm64_armv8-2a_kryo385_static/obj/external/minigbm/drv_helpers.o:(drv_get_os_option) clang-17: error: linker command failed with exit code 1 (use -v to see invocation) ------------------------------ Change-Id: I7bde9a57b930d4f527ece27ade3c294490cebd3a Signed-off-by:
Amit Pundir <amit.pundir@linaro.org>
-
- Jun 01, 2023
-
-
Amit Pundir authored
drv_get_os_option() helper routine only use property_get() check to add runtime hooks on Android. But Android supports reading runtime environment variables via getenv() as well. So this patch updates drv_get_os_option() to try getenv() first before falling back to using Android system/vendor properties. This fix helps in using predefined MINIGBM_DEBUG env variable (=nocomporession) on Android, to workaround broken UBWC on certain msm usecases. Change-Id: I4f78afb30a0381bc053e59ec508026584f617258 Signed-off-by:
Amit Pundir <amit.pundir@linaro.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4567971 Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Dominik Behr <dbehr@chromium.org>
-
- May 31, 2023
-
-
John Reck authored
From aosp/2607528 Bug: 284333373 Test: Mapper5 VTS GetUsage64 Change-Id: Iff593e2a6f3f1f08bdb77314fa3ded9473c68b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4574845 Auto-Submit: Jason Macnak <natsu@google.com> Reviewed-by:
Dominik Behr <dbehr@chromium.org> Commit-Queue: Dominik Behr <dbehr@chromium.org> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Jason Macnak <natsu@google.com>
-
- May 30, 2023
-
-
John Reck authored
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2607528 Change-Id: I35e93044be98f5c435bcfb808fb38c0a303539c7 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Yiwei Zhang authored
The latest drv_get_os_option consumes the prop name directly without lowering or etc. Meanwhile, to use strcmp instead of strncmp, we must query ro.product.name instead since the .device one has suffix. BUG=b:269982880 Change-Id: I27543975ec0c2a0bd7700ebd59c4dc5dd5dd2793 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4571850 Reviewed-by:
Dawn Han <dawnhan@google.com> Tested-by:
Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Amit Pundir <amit.pundir@linaro.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
-
- May 26, 2023
-
-
John Reck authored
Bug: 284333373 Test: Mapper5 VTS GetUsage64 Change-Id: I28f10be812039f4129d32572895d20b26d11c1fe
-
- May 10, 2023
-
-
Lloyd Pique authored
This is slightly modified version of another patch originally created by David Stevens (stevensd@chromium.org), but since reverted. https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3256451 Use blob buffers for ABGR8888 format buffers. This is necessary on ARCVM to mitigate a performance problem with the `testSurfaceTransaction_setEnableBackPressure` test from the `CtsViewTestCases`, as the test expects to be able to read back rendered buffers at 60fps. Almost all the code is the same, with the only differences (besides some minor conflict resolutions resurrecting this patch) being in the switch statement in `should_use_blob` in `virtgpu_virgl.c` where a check for ABGR8888 is added. The rest of the change is as authored by stevensd@, which requires knowing the host buffer layout before creating the blob resource, and using an LRU cache of layouts to avoid the overhead of querying the host every time a buffer is created. As noted in stevensd@'s CL, virgpu_cross_domain will be the preferred replacement to virgpu_virgl, and which is expected to have better performance without this kludge. TEST=CtsViewTestCases on hatch BUG=b:235308831 Change-Id: Ia58573a8477e0c17239d6a0768ee53782fac1dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4505920 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Auto-Submit: Lloyd Pique <lpique@chromium.org> Tested-by:
Lloyd Pique <lpique@chromium.org>
-
- May 02, 2023
-
-
Dawn Han authored
Move mt8183_camera_quirk_ into struct cross_domain_private. Add a helper `drv_get_os_option` in `drv_helper` to query os option. Advertise DRM_FORMAT_MTISP_SXYZW10 as supported format in virtgpu_cross_domain.c. Implement cross domain's own resolve_format_and_use_flags entry point. BUG=b:269982880 TEST=tested on a kukui machine after applying the change. Camera and screen recording works fine. Change-Id: Ia0d6e2cc701477aa6b9542de84e24f8aeb5a29e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4304961 Commit-Queue: Dawn Han <dawnhan@google.com> Reviewed-by:
Dominik Behr <dbehr@chromium.org> Tested-by:
Dawn Han <dawnhan@google.com>
-
Nathan Lu authored
Add BO_USE_PROTECTED use_flag to allocated a secure buffer from GEM. BUG=b:248609774 TEST="emerge-cherry libdrm minigbm" pass Cq-Depend: chromium:4482938 Change-Id: I32acaf265a128314f59e8f46fdbbed4254b8600e Signed-off-by:
Jason-JH.Lin <jason-jh.lin@mediatek.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4145439 Reviewed-by:
Dominik Behr <dbehr@chromium.org> Commit-Queue: Fei Shao <fshao@chromium.org> Tested-by:
Fei Shao <fshao@chromium.org> Reviewed-by:
Fei Shao <fshao@chromium.org>
-
Ryan Neph authored
fix a typo in combinations affecting the legacy (no explicit modifiers) allocation path. BUG=b:279974016, b:243459433 TEST=glxgears in Crostini on MTL Change-Id: I97d5a66effd82d8265bb2b977d623ee07bad5af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4492277 Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Ryan Neph <ryanneph@google.com> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Lina Versace <chadversary@chromium.org> Reviewed-by:
Matt Turner <msturner@google.com>
-
- Apr 25, 2023
-
-
Miguel Casas authored
Same as NV12, but more restricted. This will unbreak plane_test as used in Tast PlatformOverlays.24bpp_p010_overlay, which is currently broken because P010 BOs are tried to be mappe in userspace. BUG=b:226417611 TEST=plane_test --format XR24 --plane P010 --size 640x360 on brya Change-Id: Ifb7b38435bcb3ff6d911a7671a01598f0ec45f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4459793 Reviewed-by:
Dominik Behr <dbehr@chromium.org> Commit-Queue: Dominik Behr <dbehr@chromium.org> Tested-by:
Miguel Casas-Sanchez <mcasas@chromium.org> Auto-Submit: Miguel Casas-Sanchez <mcasas@chromium.org> Reviewed-by:
Hang Nguyen <hnt@chromium.org>
-
- Apr 24, 2023
-
-
Dawn Han authored
There are two gem close handles. Remove one of them and use `drv_gem_close` instead. Bug=b:266776512 TEST=cts Change-Id: I4dd1ab884626623e7d5f2024296c241cf75a9402 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4461311 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Dawn Han <dawnhan@google.com> Commit-Queue: Dawn Han <dawnhan@google.com>
-
- Apr 21, 2023
-
-
Fei Shao authored
MT8173's IMG driver doesn't seem to support these texture formats, and that causes CTS failures when we upgrade Android version to container-R. Use an allow-list approach to exclude the formats from MT8173. While at it, also do a minor renaming for alignment. BUG=b:278492435 TEST=CtsGraphicsTestCases Change-Id: Ic7ce5510f986c4cf3176b72a5f196b648387de34 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4453148 Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Fei Shao <fshao@chromium.org> Commit-Queue: Fei Shao <fshao@chromium.org>
-
- Apr 18, 2023
-
-
Sushma Venkatesh Reddy authored
Use clflushopt if it is supported instead of clflush. clflushopt is more optimized and suggested by the HW engineers. It has improved MTL unmap operation times significantly. BUG=b:274641129 TEST=camera preview should be minimum of 30fps Signed-off-by:
Nirmoy Das <nirmoy.das@intel.com> Signed-off-by:
Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com> Change-Id: I9bf7e355d5ebdfb1647c578173123bb73db5571d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4382538 Reviewed-by:
Dominik Behr <dbehr@chromium.org>
-
- Apr 09, 2023
-
-
Dawn Han authored
The multi-planar formats are being allocated into a single plane, and the minigbm exynos backend is dropped. So we can use `handle` instead of handles as of now. Remove some of the helper functions that calculate the number of planes. There is no need to check if there is more than one kernel buffer per buffer object. Added a new function `drv_gem_close` in `drv_helpers` that can be used by `drv_gem_bo_destroy` and `drv_prime_bo_import`. It can be used to clean the unused gem_handle. Bug=b:266776512 TEST=camera and screenshot work fine after deploying the change #strongbad TEST=camera and screenshot work fine after deploying the change #kukui-arc-r TEST=camera and screenshot work fine after deploying the change, tested a couple of apps in the Google Play Store, and checked file `dma_buf/bufinfo` to see there's no object leaking. #guybrush Change-Id: Ib63559504e4cb8f1a32ae90170925146613d694f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4297873 Commit-Queue: Dawn Han <dawnhan@google.com> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Dawn Han <dawnhan@google.com>
-
Dawn Han authored
Multi-planer formats are being allocated into a single plane, so `dmabuf_sizes[DRV_MAX_PLANES]` is no longer needed. There is only one `dmabuf_size` now. And use bo->handles[0] only. In the clean-up function, close handle[0] if it's not empty. Bug=b:266776512 TEST=camera and screenshot work fine after deploying the change #kukui-arc-ri Change-Id: I068bcafbfbaf1b2be543aec3a4d87e1870a10d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4338596 Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Dawn Han <dawnhan@google.com> Tested-by:
Dawn Han <dawnhan@google.com>
-
- Apr 04, 2023
-
-
Jason Macnak authored
Merge "Revert "ANDROID: gralloc: Temporarily disable PixelFormat::R_8"" am: e4fc0b83 am: f900bc8d Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2517995 Change-Id: I4ca376203b85914b645a3dc0ecb83f423b12f640 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Apr 03, 2023
-
-
Jason Macnak authored
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2517995 Change-Id: I21be3706e36c2da0076b6932a82451bdf1c04cd5 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Mar 31, 2023
-
-
Jason Macnak authored
This reverts commit 87b0f9bd. The necessary bits are in ANGLE and SwiftShader now. Bug: b/259551816 Change-Id: I851a4102d0a4edda37dc6b3741bab70dd056c262 Test: cvd start --gpu_mode=guest_swiftshader Test: atest librenderengine_test Test: cts -m CtsNativeHardwareTestCases
-
- Mar 28, 2023
-
-
Yiwei Zhang authored
BUG=n/a TEST=emerge-$BOARD minigbm Change-Id: I517289a9abb82f9dc228320f70edc8f28aa1ec6e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4373889 Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by:
Dawn Han <dawnhan@google.com> Reviewed-by:
Hsin-Yi Wang <hsinyi@chromium.org> Reviewed-by:
Fei Shao <fshao@chromium.org> Reviewed-by:
Miguel Casas-Sanchez <mcasas@chromium.org> Tested-by:
Yiwei Zhang <zzyiwei@chromium.org>
-
- Mar 24, 2023
-
-
Yiwei Zhang authored
Just use the default 64 alignment for blob. This further avoids a huge unnecessary alloc. BUG=b:270850022 BUG=b:242495495 TEST=things work Change-Id: I8a9c554265749b8d690d993f04e61d15b4402dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4368800 Reviewed-by:
Fei Shao <fshao@chromium.org> Reviewed-by:
Hsin-Yi Wang <hsinyi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Hsin-Yi Wang <hsinyi@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Fei Shao <fshao@chromium.org> Tested-by:
Fei Shao <fshao@chromium.org> Tested-by:
Yiwei Zhang <zzyiwei@chromium.org>
-
- Mar 23, 2023
-
-
Yiwei Zhang authored
HAL_PIXEL_FORMAT_BLOB gets resolved into DRM_FORMAT_R8 with height of 1. Avoid doing any vertical alignment for this case. This format should be exempt from the 32 vertical alignment requirement from mtk video encoder in the kernel driver. BUG=b:270850022 BUG=b:242495495 TEST=test and app work Change-Id: Ic635c708597b5f5548ad95f34a81943d4cc2c801 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4364500 Reviewed-by:
Hsin-Yi Wang <hsinyi@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org> Tested-by:
Yiwei Zhang <zzyiwei@chromium.org>
-
- Mar 20, 2023
-
-
Chia-I Wu authored
The test requires the strides to be aligned consistently despite the use flags. This is a test bug (b/167947334) before R. BUG=b:265746435 TEST=android.hardware.camera2.cts.ImageWriterTest#testYuvImageWriterReaderOperation Change-Id: I0f56b12f46c1a2d65ec7096d337c562459c35ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4351634 Tested-by:
Chia-I Wu <olv@google.com> Reviewed-by:
Ryan Neph <ryanneph@google.com> Commit-Queue: Chia-I Wu <olv@google.com>
-
- Mar 16, 2023
-
-
Chia-I Wu authored
sommelier makes VIRTWL_IOCTL_NEW_DMABUF requests for 2D apps. crosvm's virtio-wl allocates linear BOs in response and expects them to be presentable. BUG=b:273797429 TEST=xeyes and gedit in crostini Change-Id: Id5a955e5c22342ee11e9e333720eb95ac08fd175 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4343374 Tested-by:
Chia-I Wu <olv@google.com> Reviewed-by:
Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Chia-I Wu <olv@google.com>
-
Yiwei Zhang authored
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2490736 Change-Id: I92471b187245769750c380344ba14cbb0f284f03 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-