-
- Downloads
qapi block: Elide redundant has_FOO in generated C
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/block*.json.
Said commit explains the transformation in more detail.
There is one instance of the invariant violation mentioned there:
qcow2_signal_corruption() passes false, "" when node_name is an empty
string. Take care to pass NULL then.
The previous two commits cleaned up two more.
Additionally, helper bdrv_latency_histogram_stats() loses its output
parameters and returns a value instead.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by:
Markus Armbruster <armbru@redhat.com>
Message-Id: <20221104160712.3005652-11-armbru@redhat.com>
[Fixes for #ifndef LIBRBD_SUPPORTS_ENCRYPTION and MacOS squashed in]
Showing
- block/block-backend.c 1 addition, 1 deletionblock/block-backend.c
- block/copy-before-write.c 1 addition, 1 deletionblock/copy-before-write.c
- block/dirty-bitmap.c 0 additions, 1 deletionblock/dirty-bitmap.c
- block/export/export.c 1 addition, 1 deletionblock/export/export.c
- block/export/vduse-blk.c 1 addition, 2 deletionsblock/export/vduse-blk.c
- block/gluster.c 0 additions, 3 deletionsblock/gluster.c
- block/monitor/block-hmp-cmds.c 19 additions, 29 deletionsblock/monitor/block-hmp-cmds.c
- block/qapi-sysemu.c 25 additions, 48 deletionsblock/qapi-sysemu.c
- block/qapi.c 22 additions, 40 deletionsblock/qapi.c
- block/qcow.c 5 additions, 5 deletionsblock/qcow.c
- block/qcow2.c 8 additions, 10 deletionsblock/qcow2.c
- block/qed.c 1 addition, 1 deletionblock/qed.c
- block/quorum.c 1 addition, 1 deletionblock/quorum.c
- block/rbd.c 6 additions, 11 deletionsblock/rbd.c
- block/ssh.c 1 addition, 1 deletionblock/ssh.c
- blockdev-nbd.c 4 additions, 5 deletionsblockdev-nbd.c
- blockdev.c 65 additions, 99 deletionsblockdev.c
- blockjob.c 0 additions, 2 deletionsblockjob.c
- monitor/hmp-cmds.c 1 addition, 2 deletionsmonitor/hmp-cmds.c
- qemu-img.c 6 additions, 7 deletionsqemu-img.c
Loading
Please register or sign in to comment