Skip to content
Snippets Groups Projects
  • Laurent Vivier's avatar
    5166fe0a
    qapi: net: add stream and dgram netdevs · 5166fe0a
    Laurent Vivier authored
    
    Copied from socket netdev file and modified to use SocketAddress
    to be able to introduce new features like unix socket.
    
    "udp" and "mcast" are squashed into dgram netdev, multicast is detected
    according to the IP address type.
    "listen" and "connect" modes are managed by stream netdev. An optional
    parameter "server" defines the mode (off by default)
    
    The two new types need to be parsed the modern way with -netdev, because
    with the traditional way, the "type" field of netdev structure collides with
    the "type" field of SocketAddress and prevents the correct evaluation of the
    command line option. Moreover the traditional way doesn't allow to use
    the same type (SocketAddress) several times with the -netdev option
    (needed to specify "local" and "remote" addresses).
    
    The previous commit paved the way for parsing the modern way, but
    omitted one detail: how to pick modern vs. traditional, in
    netdev_is_modern().
    
    We want to pick based on the value of parameter "type".  But how to
    extract it from the option argument?
    
    Parsing the option argument, either the modern or the traditional way,
    extracts it for us, but only if parsing succeeds.
    
    If parsing fails, there is no good option.  No matter which parser we
    pick, it'll be the wrong one for some arguments, and the error
    reporting will be confusing.
    
    Fortunately, the traditional parser accepts *anything* when called in
    a certain way.  This maximizes our chance to extract the value of
    "type", and in turn minimizes the risk of confusing error reporting.
    
    Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
    Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
    Acked-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
    5166fe0a
    History
    qapi: net: add stream and dgram netdevs
    Laurent Vivier authored
    
    Copied from socket netdev file and modified to use SocketAddress
    to be able to introduce new features like unix socket.
    
    "udp" and "mcast" are squashed into dgram netdev, multicast is detected
    according to the IP address type.
    "listen" and "connect" modes are managed by stream netdev. An optional
    parameter "server" defines the mode (off by default)
    
    The two new types need to be parsed the modern way with -netdev, because
    with the traditional way, the "type" field of netdev structure collides with
    the "type" field of SocketAddress and prevents the correct evaluation of the
    command line option. Moreover the traditional way doesn't allow to use
    the same type (SocketAddress) several times with the -netdev option
    (needed to specify "local" and "remote" addresses).
    
    The previous commit paved the way for parsing the modern way, but
    omitted one detail: how to pick modern vs. traditional, in
    netdev_is_modern().
    
    We want to pick based on the value of parameter "type".  But how to
    extract it from the option argument?
    
    Parsing the option argument, either the modern or the traditional way,
    extracts it for us, but only if parsing succeeds.
    
    If parsing fails, there is no good option.  No matter which parser we
    pick, it'll be the wrong one for some arguments, and the error
    reporting will be confusing.
    
    Fortunately, the traditional parser accepts *anything* when called in
    a certain way.  This maximizes our chance to extract the value of
    "type", and in turn minimizes the risk of confusing error reporting.
    
    Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
    Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
    Acked-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Signed-off-by: default avatarJason Wang <jasowang@redhat.com>