Skip to content
Snippets Groups Projects
  • Paolo Bonzini's avatar
    a50c99bc
    monitor: mark mixed functions that can suspend · a50c99bc
    Paolo Bonzini authored
    
    There should be no paths from a coroutine_fn to aio_poll, however in
    practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
    path.  By marking mixed functions, we can track accurately the call paths
    that execute entirely in coroutine context, and find more missing
    coroutine_fn markers.  This results in more accurate checks that
    coroutine code does not end up blocking.
    
    If the marking were extended transitively to all functions that call
    these ones, static analysis could be done much more efficiently.
    However, this is a start and makes it possible to use vrc's path-based
    searches to find potential bugs where coroutine_fns call blocking functions.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    a50c99bc
    History
    monitor: mark mixed functions that can suspend
    Paolo Bonzini authored
    
    There should be no paths from a coroutine_fn to aio_poll, however in
    practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
    path.  By marking mixed functions, we can track accurately the call paths
    that execute entirely in coroutine context, and find more missing
    coroutine_fn markers.  This results in more accurate checks that
    coroutine code does not end up blocking.
    
    If the marking were extended transitively to all functions that call
    these ones, static analysis could be done much more efficiently.
    However, this is a start and makes it possible to use vrc's path-based
    searches to find potential bugs where coroutine_fns call blocking functions.
    
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
qmp-dispatch.c 7.48 KiB