Skip to content
Snippets Groups Projects
  1. Jan 13, 2022
    • Masahiro Yamada's avatar
      kbuild: drop $(size_append) from cmd_zstd · 64d8aaa4
      Masahiro Yamada authored
      
      The appended file size is only used by the decompressors, which some
      architectures support.
      
      As the comment "zstd22 is used for kernel compression" says, cmd_zstd22
      is used in arch/{mips,s390,x86}/boot/compressed/Makefile.
      
      On the other hand, there is no good reason to append the file size to
      cmd_zstd since it is used for other purposes.
      
      Actually cmd_zstd is only used in usr/Makefile, where the appended file
      size is rather harmful.
      
      The initramfs with its file size appended is considered as corrupted
      data, so commit 65e00e04 ("initramfs: refactor the initramfs build
      rules") added 'override size_append := :' to make it no-op.
      
      As a conclusion, this $(size_append) should not exist here.
      
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Reviewed-by: default avatarNicolas Schier <n.schier@avm.de>
      64d8aaa4
    • Masahiro Yamada's avatar
      sh: rename suffix-y to suffix_y · 82977af9
      Masahiro Yamada authored
      'export suffix-y' does not work reliably because hyphens are disallowed
      in shell variables.
      
      A similar issue was fixed by commit 2bfbe788 ("kbuild: Do not use
      hyphen in exported variable name").
      
      If I do similar in dash, ARCH=sh fails to build.
      
        $ mv linux linux~
        $ cd linux~
        $ dash
        $ make O=foo/bar ARCH=sh CROSS_COMPILE=sh4-linux-gnu- defconfig all
        make[1]: Entering directory '/home/masahiro/linux~/foo/bar'
          [ snip ]
        make[4]: *** No rule to make target 'arch/sh/boot/compressed/vmlinux.bin.', needed by 'arch/sh/boot/compressed/piggy.o'.  Stop.
        make[3]: *** [/home/masahiro/linux~/arch/sh/boot/Makefile:40: arch/sh/boot/compressed/vmlinux] Error 2
        make[2]: *** [/home/masahiro/linux~/arch/sh/Makefile:194: zImage] Error 2
        make[1]: *** [/home/masahiro/linux~/Makefile:350: __build_one_by_one] Error 2
        make[1]: Leaving directory '/home/masahiro/linux~/foo/bar'
        make: *** [Makefile:219: __sub-make] Error 2
      
      The maintainer of GNU Make stated that there is no consistent way to
      export variables that do not meet the shell's naming criteria.
      (https://savannah.gnu.org/bugs/?55719
      
      )
      
      Consequently, you cannot use hyphens in exported variables.
      
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Reviewed-by: default avatarNicolas Schier <n.schier@avm.de>
      82977af9
  2. Jan 08, 2022
  3. Dec 11, 2021
  4. Dec 02, 2021
  5. Nov 28, 2021
  6. Nov 27, 2021
    • Linus Torvalds's avatar
      Merge tag '5.16-rc2-ksmbd-fixes' of git://git.samba.org/ksmbd · 3498e7f2
      Linus Torvalds authored
      Pull ksmbd fixes from Steve French:
       "Five ksmbd server fixes, four of them for stable:
      
         - memleak fix
      
         - fix for default data stream on filesystems that don't support xattr
      
         - error logging fix
      
         - session setup fix
      
         - minor doc cleanup"
      
      * tag '5.16-rc2-ksmbd-fixes' of git://git.samba.org/ksmbd:
        ksmbd: fix memleak in get_file_stream_info()
        ksmbd: contain default data stream even if xattr is empty
        ksmbd: downgrade addition info error msg to debug in smb2_get_info_sec()
        docs: filesystem: cifs: ksmbd: Fix small layout issues
        ksmbd: Fix an error handling path in 'smb2_sess_setup()'
      3498e7f2
Loading