- Jan 08, 2024
-
-
Mattijs Korpershoek authored
In V4L2Decoder::start(), we call setupInputFormat() to configure the initial decoding resolution. This is done by passing a default Size() class, which has a size of (-1,-1). According to [1], when calling VIDIOC_S_FMT, the driver can adapt the requested format, which is what the wave5 driver does. By default, the wave5 driver picks up the maximum available resolution: [ 1047.307387][ T3573] wave5_update_pix_fmt 8192x4320 sizeimage: 53084160 Because of that, the initial buffers are too big and connot be allocated by the kernel: [ 1047.981455][ T3573] videobuf2_common: [out-00000000d79789f3] __prepare_dmabuf: failed to attach dmabuf [ 1047.990842][ T3573] videobuf2_common: [out-00000000d79789f3] __buf_prepare: buffer preparation failed: -14 Fix this by using a hard-coding 1080p as an initial input size. [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-g-fmt.html#c.V4L.VIDIOC_S_FMT Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
Mattijs Korpershoek authored
The AM62P gralloc implementation defaults to NV12 when the YCBCR_420_888 format is requested. This is a requirement for using libcamera. Make sure we configure the video decoder to use the same pixel format. Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
Currently when using the v4l2_codec2 HAL as documented, it will fail to function and one will see the following error in the logcat: 03-11 05:25:09.121 568 2059 D CCodecBufferChannel: [c2.v4l2.avc.decoder#295] Created input block pool with allocatorID 16 => poolID 19 - OK (0) 03-11 05:25:09.122 568 2059 D C2PlatformStorePluginLoader: Failed to load library: libc2plugin_store.so (dlopen failed: library "libc2plugin_store.so" not found) 03-11 05:25:09.122 568 2059 D C2PlatformStorePluginLoader: Handle or CreateAllocator symbol is null It seems this is due to the C2PlatformStorePluginLoader being system library which tries to load and call out to libc2plugin_store, which isn't allowed (vendor can call to system, but system can't call to vendor). This patch sets libc2plugin_store library to be vendor_available which sets it in the system image. Apparently this isn't the right solution, but without it the libraries will not load. It seems the libc2plugin_store loader logic may not be valid post-Treble? https://cs.android.com/android/platform/superproject/+/master:frameworks/av/media/codec2/vndk/C2PlatformStorePluginLoader.cpp;l=38 We need to understand what a proper solution would be, or what vendors use for this. Bug: 170199771 Test: none Signed-off-by:
Dmitry Shmidt <dimitrysh@google.com> [jstultz: Added some detail to the commit message, narrowed change to just libc2plugin_store] Signed-off-by:
John Stultz <john.stultz@linaro.org> Change-Id: I7e4486ad95fb32a75ae9cec075672de0c7de2586 Link: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2007320 Link: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2234008 Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
- Nov 03, 2023
-
-
For the bindarized HAL, multilib doesn't make any sense. Also, it confuses the init sometimes if both 64 and 32 variants are available on the board. Change-Id: I33854241f2976ac54cdb7731cdcc93e94021d30c Signed-off-by:
Roman Stratiienko <r.stratiienko@gmail.com> Link: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2780997 Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
- Oct 30, 2023
-
-
The code owner then owns the manifest the vintf fragment. Remove IConfigurable because it isn't declared in the compatibility matrix. It isn't registered to hwservice_manager either in the implementation. Bug: 291157411 Test: ARC++ boots. Change-Id: I1616bf2ae90327e87bf13cc379e85927333eb0ed Merged-In: I1616bf2ae90327e87bf13cc379e85927333eb0ed (cherry picked from commit 7e153427) Signed-off-by:
Mattijs Korpershoek <mkorpershoek@baylibre.com>
-
- Dec 13, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: Idd52a4c313a702976e192acb288b169ff8be93f0
-
- Dec 12, 2022
-
-
Automerger Merge Worker authored
Merge "[automerger skipped] Merge Android 13 QPR1 am: 1abdcba6 -s ours" into stage-aosp-master am: d3131fb5 -s ours am: cbc72238 -s ours am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: Ibfae74a433ceb2e27900328161d3625b77e1765c Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
[automerger skipped] Merge Android 13 QPR1 am: 1abdcba6 -s ours am: 1af175bc -s ours am: 43f7d484 -s ours am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: Id389befd2ca444d3d3f2657be3c4595553ebcd6b Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
[automerger skipped] Merge Android 13 QPR1 am: 1abdcba6 -s ours am: 141ecb3f -s ours am: 615f27ae -s ours am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: Ie45a5b8bd4baaeaba1ccdf5f298cfa7f81e16b88 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Dec 10, 2022
-
-
Automerger Merge Worker authored
Merge "[automerger skipped] Merge Android 13 QPR1 am: 1abdcba6 -s ours" into stage-aosp-master am: d3131fb5 -s ours am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: I6d5a53cec9a1da146a9301fe8e040ae1af992157 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: I2cfc9b09620a70e9d22341d78fd32badb647a8c6 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: Ie5141a291d75dbfaa21235e27dead12469a81685 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Automerger Merge Worker authored
-
Xin Li authored
am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: I4b1e99ff7289ad6f08ab82b557d7cc83adc19749 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In Id2cc220b9122eec412823f577f07ecd82bad60fc with SHA-1 3db9508b is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2336996 Change-Id: If02d91856a21f16cc087ce775633355a53815a2e Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Dec 09, 2022
-
-
Xin Li authored
Bug: 261731544 Merged-In: Id2cc220b9122eec412823f577f07ecd82bad60fc Change-Id: I1b1441bcd03b64013819a8fc158879554dd5a819
-
- Oct 12, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: I40bbb30cfca844c500e5fc0d255148b6cf9a7f15
-
- Oct 11, 2022
-
-
Xin Li authored
[automerger skipped] Merge tm-qpr-dev-plus-aosp-without-vendor@9129937 am: 2d9f68b8 -s ours am: 4c96bdcd -s ours am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/20136969 Change-Id: I3015cb21d5ed2d926f5f1e6a662838e819a66bfb Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/20136969 Change-Id: I8f501659b6b44db71380541e90b2449e1d91c7a4 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Oct 06, 2022
-
-
Xin Li authored
Bug: 248070379 Merged-In: I3ceefaad9b420f86e4f0b524e6f0b5649af9997b Change-Id: I646c183bf1d60d6732e01092e8868e1d177b7936
-
- Sep 08, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: I856d47a6b89df1c0d9f7dd2d93259561bae5e145
-
- Sep 06, 2022
-
-
Bartłomiej Grzesik authored
This patch adds a Android system property persist.vendor.v4l2_codec2.disable_vbr. The property allows user to disable option to encode with variable bitrate in runtime. This change is required for a temporary workaround for b/235771157. Bug: 235771157, 238835187 Test: android.video.cts.VideoEncoderDecoderTest#testVp8Other0Perf0640x0360 Change-Id: I4a9931431354193968f8255d0d501aed02ee3508 (cherry picked from commit f9f4b5681ff4fc22cd83192b17693d90922134c7)
-
- Aug 18, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: I95f21ceaa8ce2cca1e02ca5dcf208361b92fd391
-
- Aug 17, 2022
-
-
Xin Li authored
[automerger skipped] DO NOT MERGE - Merge Android 13 am: 282b0666 -s ours am: 9be91caf -s ours am: 4aa5a52a -s ours am: 121895ee -s ours am skip reason: subject contains skip directive Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2186764 Change-Id: Ia0407de34a8151a54f184cacf1dd1aa806b5e8b8 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
[automerger skipped] DO NOT MERGE - Merge Android 13 am: 282b0666 -s ours am: 9be91caf -s ours am: 4aa5a52a -s ours am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2186764 Change-Id: I4b19c54ffd3a24fa1d4400d09f1860fe4df55c90 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2186764 Change-Id: I30de62144cbda5d852f2d06a221aa00f2e7ab1d7 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://android-review.googlesource.com/c/platform/external/v4l2_codec2/+/2186764 Change-Id: I19a758c7ac1fc7475dd48c2d2b481a57b50daeaf Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Aug 16, 2022
-
-
Xin Li authored
Bug: 242648940 Merged-In: I3ceefaad9b420f86e4f0b524e6f0b5649af9997b Change-Id: I04b3505c478d96f4676ec6bc3268dba24f2123fa
-
- Jul 01, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: I5ca0dd1d7e51f39e385553b18fe3ae1236890214
-
- Jun 30, 2022
-
-
Xin Li authored
[automerger skipped] Merge tm-dev-plus-aosp-without-vendor@8763363 am: 1425bf6c -s ours am: 92bfd9cd -s ours am: 12124d1c -s ours am: 71d9eb28 -s ours am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19094255 Change-Id: I91123966256a92125c007e989057efe2e26fb323 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
[automerger skipped] Merge tm-dev-plus-aosp-without-vendor@8763363 am: 1425bf6c -s ours am: 92bfd9cd -s ours am: 12124d1c -s ours am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19094255 Change-Id: If8008f2fa665f2ae61be7e0a96ec76904249f447 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
[automerger skipped] Merge tm-dev-plus-aosp-without-vendor@8763363 am: 1425bf6c -s ours am: 92bfd9cd -s ours am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19094255 Change-Id: I111ec9b3622c9310911cf73769fcae7148903a55 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Xin Li authored
am skip reason: Merged-In I3ceefaad9b420f86e4f0b524e6f0b5649af9997b with SHA-1 39f241ae is already in history Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19094255 Change-Id: Idce765aba832c1c6330367e6761d362c3c233ba4 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
- Jun 28, 2022
-
-
Xin Li authored
Bug: 236760014 Merged-In: I3ceefaad9b420f86e4f0b524e6f0b5649af9997b Change-Id: I5fd9a4d5bd3c0add0c25dea8cf1b8cde51a80da1
-
- Jun 25, 2022
-
-
Android Build Coastguard Worker authored
Change-Id: I179cc89090bcce5eb9ba00b0d5752d7ef0a1040d
-
- Jun 24, 2022
-
-
Automerger Merge Worker authored
Merge "V4L2EncodeComponent: fix build error am: 3db9508b am: 15c4e662" into tm-d1-dev-plus-aosp am: f190b2ef am: c9452d28 Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19033643 Change-Id: I6fec6b230daa539d29b6eae11aa0c38f0c64bea6 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Alexandre Courbot authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19033643 Change-Id: I7970e8a0bb4a3b94237a6b591c02e0b90fec481d Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Alexandre Courbot authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19033643 Change-Id: I78c6cadf78bc0c7333540bde67a5b39ee903ca8e Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Automerger Merge Worker authored
Merge "V4L2EncodeComponent: fix build error am: 3db9508b am: 15c4e662" into tm-d1-dev-plus-aosp am: f190b2ef Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19033643 Change-Id: I0d8505765ac95f52984a29dcb6c3671cea4a7d74 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-
Alexandre Courbot authored
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/v4l2_codec2/+/19033643 Change-Id: Ia9e5dd016790bee13db59bb77e69c280b12ea1b5 Signed-off-by:
Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-