From 0a03986210fb134892726a2d9f1708d2c54a3a07 Mon Sep 17 00:00:00 2001
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Date: Fri, 5 Jan 2024 13:59:32 +0100
Subject: [PATCH] HACK: TI: v4l2_codec2: decoder: hard-code 1080p as initial
size
In V4L2Decoder::start(), we call setupInputFormat() to configure the initial
decoding resolution.
This is done by passing a default Size() class, which has a size of (-1,-1).
According to [1], when calling VIDIOC_S_FMT, the driver can adapt the requested
format, which is what the wave5 driver does.
By default, the wave5 driver picks up the maximum available resolution:
[ 1047.307387][ T3573] wave5_update_pix_fmt 8192x4320 sizeimage: 53084160
Because of that, the initial buffers are too big and connot be allocated by the kernel:
[ 1047.981455][ T3573] videobuf2_common: [out-00000000d79789f3] __prepare_dmabuf: failed to attach dmabuf
[ 1047.990842][ T3573] videobuf2_common: [out-00000000d79789f3] __buf_prepare: buffer preparation failed: -14
Fix this by using a hard-coding 1080p as an initial input size.
[1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-g-fmt.html#c.V4L.VIDIOC_S_FMT
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
components/V4L2Decoder.cpp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/components/V4L2Decoder.cpp b/components/V4L2Decoder.cpp
index a9a52d8..ab29421 100644
--- a/components/V4L2Decoder.cpp
+++ b/components/V4L2Decoder.cpp
@@ -175,7 +175,10 @@ bool V4L2Decoder::setupInputFormat(const uint32_t inputPixelFormat, const size_t
}
// Setup the input format.
- auto format = mInputQueue->setFormat(inputPixelFormat, ui::Size(), inputBufferSize, 0);
+ // HACK: By default, the wave5 driver picks up the maximum available resolution
+ // [ 1047.307387][ T3573] wave5_update_pix_fmt 8192x4320 sizeimage: 53084160
+ // This cannot be allocated in the kernel, so hard-code a 1080p size instead.
+ auto format = mInputQueue->setFormat(inputPixelFormat, ui::Size(1920, 1080), inputBufferSize, 0);
if (!format) {
ALOGE("Failed to call IOCTL to set input format.");
return false;
--
GitLab